Skip to content

Fix "more restores than saves" exception #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix "more restores than saves" exception #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions android/src/main/java/com/horcrux/svg/GroupView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ void drawGroup(final Canvas canvas, final Paint paint, final float opacity) {
final GroupView self = this;
final RectF groupRect = new RectF();

int layerCount = -1;
if (mOpacity != 1) {
if (mLayerBitmap == null) {
mLayerBitmap =
Expand All @@ -107,7 +108,7 @@ void drawGroup(final Canvas canvas, final Paint paint, final float opacity) {
mLayerCanvas.setBitmap(mLayerBitmap);
}
// Copy current matrix from original canvas
mLayerCanvas.save();
layerCount = mLayerCanvas.save();
mLayerCanvas.setMatrix(canvas.getMatrix());
} else {
mLayerCanvas = canvas;
Expand Down Expand Up @@ -161,7 +162,7 @@ void drawGroup(final Canvas canvas, final Paint paint, final float opacity) {

if (mOpacity != 1) {
// Restore copied canvas and temporary reset original canvas matrix to draw bitmap 1:1
mLayerCanvas.restore();
if (layerCount > 0) mLayerCanvas.restoreToCount(layerCount);
int saveCount = canvas.save();
canvas.setMatrix(null);
mLayerPaint.setAlpha((int) (mOpacity * 255));
Expand Down
Loading