fix: drawing unicode emojis on iOS #2785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some testing with my updated reproduction, it seems the emoji position is flipped horizontally and emoji don't fit well with other text 😅 https://gist.github.com/TPXP/a2595d2f2f85c4524f470fc343787450 |
kacperzolkiewski
force-pushed
the
fixPixelatedEmoji
branch
from
b7a5281 to
2e8d2c0
Compare
|
This works well on my side too, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2783
This PR fixes the emoji rendering:
Changes
[emojiLabel.layer renderInContext:context]into[emojiLabel drawTextInRect:emojiLabel.bounds]to overcome emojis pixelationTest Plan
Run example from issue: #2783 and check if emojis are pixelated.
Compatibility
Checklist
README.md__tests__folder