Skip to content

Conversation

kacperzolkiewski
Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski commented Oct 17, 2025

Summary

Fixes: #2796

Previously, in the new architecture, shadow nodes for elements such as Circle, Rect and other SVG components were initialized with zero dimensions.
This caused issues with press interactions during move action. Yoga was unable to locate the corresponding shadow node resulting in the press event being canceled.
This PR updates the implementation to propagate each element’s actual native layout metrics to its shadow node.
By ensuring the shadow nodes reflect accurate geometry, Yoga can now correctly resolve touch targets fixing the issue where press actions were being incorrectly canceled.

Test Plan

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review October 21, 2025 10:08
@kacperzolkiewski kacperzolkiewski changed the title Propagate elements metrics to their shadow nodes Fix: propagate elements metrics to their shadow nodes Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path onPress prop not triggered since upgrading to expo 54

2 participants