Open
Conversation
JBRS307
force-pushed
the
@jbrs/efficient-seek
branch
from
02e1bea to
9acb24f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the MP4 seek logic by replacing an inefficient O(n) sample-by-sample iteration with an O(m) algorithm that uses the STTS (Sample-to-Time) and STSS (Sync Sample) MP4 box structures. The old implementation read every sample individually to find the seek position, while the new one calculates the position using metadata boxes and binary search, eliminating unnecessary I/O operations.
Changes:
- Refactors
find_seek_start_sampleto use STTS box entries for efficient sample position calculation instead of reading each sample - Uses
partition_pointbinary search on STSS entries to find the nearest sync sample before the seek point - Changes function signature from
&mut selfto&self, eliminating unnecessary mutability requirement - Removes the
TODO: improve performancecomment along with the inefficient implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wkozyra95
requested changes
Apr 3, 2026
| let mut present_from_index = None; | ||
|
|
||
| // Finds the first sample after the provided seek point. | ||
| for entry in &stts.entries { |
Member
There was a problem hiding this comment.
This does not work if there is only one entry in stts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1858