Unit test DR is set when FIR is provided

Author: softwareengineerprogrammer

src/geophires_x/Economics.py

@@ -2166,24 +2166,27 @@ def read_parameters(self, model: Model) -> None:
         model.logger.info(f'complete {__class__!s}: {sys._getframe().f_code.co_name}')
 
     def sync_interest_rate(self, model):
+        def discount_rate_display() -> str:
+            return str(self.discountrate.quantity()).replace(' dimensionless', '')
+
         if self.discountrate.Provided ^ self.FixedInternalRate.Provided:
             if self.discountrate.Provided:
                 self.FixedInternalRate.value = self.discountrate.quantity().to(
                     convertible_unit(self.FixedInternalRate.CurrentUnits)).magnitude
                 model.logger.info(f'Set {self.FixedInternalRate.Name} to {self.FixedInternalRate.quantity()} '
-                                  f'because {self.discountrate.Name} was provided ({self.discountrate.value})')
+                                  f'because {self.discountrate.Name} was provided ({discount_rate_display()})')
             else:
                 self.discountrate.value = self.FixedInternalRate.quantity().to(
                     convertible_unit(self.discountrate.CurrentUnits)).magnitude
                 model.logger.info(
-                    f'Set {self.discountrate.Name} to {self.discountrate.value} because '
+                    f'Set {self.discountrate.Name} to {discount_rate_display()} because '
                     f'{self.FixedInternalRate.Name} was provided ({self.FixedInternalRate.quantity()})')
 
         if self.discountrate.Provided and self.FixedInternalRate.Provided \
             and self.discountrate.quantity().to(convertible_unit(self.FixedInternalRate.CurrentUnits)).magnitude \
                 != self.FixedInternalRate.value:
             model.logger.warning(f'{self.discountrate.Name} and {self.FixedInternalRate.Name} provided with different '
-                                 f'values ({self.discountrate.value}; {self.FixedInternalRate.quantity()}). '
+                                 f'values ({discount_rate_display()}; {self.FixedInternalRate.quantity()}). '
                                  f'It is recommended to only provide one of these values.')
 
         self.interest_rate.value = self.discountrate.quantity().to(convertible_unit(self.interest_rate.CurrentUnits)).magnitude

tests/test_geophires_x.py

@@ -553,9 +553,28 @@ def input_params(discount_rate=None, fixed_internal_rate=None):
             return GeophiresInputParameters(params)
 
         client = GeophiresXClient()
-        with self.assertLogs(level='INFO') as logs:  # noqa: F841
+
+        # noinspection PyPep8Naming
+        def assertHasLogRecordWithMessage(logs_, message):
+            assert message in [record.message for record in logs_.records]
+
+        with self.assertLogs(level='INFO') as logs:
             result = client.get_geophires_result(input_params(discount_rate='0.042'))
 
             assert result is not None
             assert result.result['ECONOMIC PARAMETERS']['Interest Rate']['value'] == 4.2
             assert result.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'] == '%'
+            assertHasLogRecordWithMessage(
+                logs, 'Set Fixed Internal Rate to 4.2 percent because Discount Rate was provided (0.042)'
+            )
+
+        with self.assertLogs(level='INFO') as logs2:
+            result2 = client.get_geophires_result(input_params(fixed_internal_rate='4.2'))
+
+            assert result2 is not None
+            assert result2.result['ECONOMIC PARAMETERS']['Interest Rate']['value'] == 4.2
+            assert result2.result['ECONOMIC PARAMETERS']['Interest Rate']['unit'] == '%'
+
+            assertHasLogRecordWithMessage(
+                logs2, 'Set Discount Rate to 0.042 because Fixed Internal Rate was provided (4.2 percent)'
+            )