forked from NREL/GEOPHIRES-X
-
Notifications
You must be signed in to change notification settings - Fork 1
Gringarten-Stehfest Precision [v3.9.52] #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
softwareengineerprogrammer
merged 14 commits into
main
from
gringarten-stehfest-precision-3
Sep 2, 2025
Merged
Gringarten-Stehfest Precision [v3.9.52] #103
softwareengineerprogrammer
merged 14 commits into
main
from
gringarten-stehfest-precision-3
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unit test for precision)
1 task
…neerprogrammer/GEOPHIRES/pull/103/files#r2301936093); temporarily ignore it with TODO to configure
…mit modified global context as an unintended side effect)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameterize Reservoir inverse laplace transform precision as
Gringarten-Stehfest Precision
to allow for increased performance, with potential tradeoff in accuracy. (Similar to Time steps per year)Testing & Verification
Fervo_Project_Cape-4
Monte Carlo - interval distribution of precision 8-15:TODO: