Skip to content

Royalties [v3.9.57] #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 33 commits into from
Closed

Royalties [v3.9.57] #105

wants to merge 33 commits into from

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Sep 15, 2025 •
edited
Loading

Description

Addresses NREL#421 for SAM Economic Models

image image image image image

Testing & Verification

  1. Added new unit tests
  2. Added new example example_SAM-single-owner-PPA-4.: 50 MWe with Royalties
  3. Tested in web interface
  4. Manually tested/sanity-checked
    1. image

TODO:

  1. CHANGELOG entry
  2. Add a test for combined royalties and add-ons
  3. Clarify taxes for royalties
  4. Royalties schedule (instead of fixed value)
  5. Update documentation
  6. Royalty collector economics
  7. Include annual average in GEOPHIRES OPEX (separate line item + include in total)
  8. Reconcile with fixed total OPEX

@softwareengineerprogrammer softwareengineerprogrammer added the enhancement New feature or request label Sep 15, 2025
@softwareengineerprogrammer
Mark TODO remove or clarify project payback period: NREL#413
b5191f2
@softwareengineerprogrammer
Include royalties in opex output/total opex (WIP)
784bccc
@softwareengineerprogrammer
Regenerate schema with Royalties output param
11c3314
@softwareengineerprogrammer
Assert that opex line items, including royalties, sum up to total
8af6e17
@softwareengineerprogrammer
Bump version: 3.9.54 → 3.9.55
a999d09
@softwareengineerprogrammer
update unit test
5c989e9
@softwareengineerprogrammer
Change output param name to 'Average Annual Royalty Cost'
274ca28
@softwareengineerprogrammer
Fix incorrect method of setting royalties output param value
ef7ac09
@softwareengineerprogrammer
Internally distinguish between SAM econ royalty cost time series and …
97203de 
…main econ average annual value
@softwareengineerprogrammer
WIP - calculate Royalty Holder NPV
a002381
@softwareengineerprogrammer
assert royalty holder NPV
0929835
@softwareengineerprogrammer
finish impl of royalty holder outputs
4adc2a1
@softwareengineerprogrammer
Update documentation. Throw exception if royalty rate provided for no…
7dd1dbe 
…n-SAM-EM inputs
@softwareengineerprogrammer
SAM-EM royalties documentation (parameter mapping + dedicated section)
2a522cc
@softwareengineerprogrammer softwareengineerprogrammer changed the title Royalty economics Royalties Sep 15, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title Royalties Royalties [v3.9.56] Sep 15, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title Royalties [v3.9.56] Royalties [v3.9.XX] Sep 16, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title Royalties [v3.9.XX] Royalties [v3.9.57] Sep 16, 2025
@softwareengineerprogrammer
Copy link
Owner Author

Rebased: #106

@softwareengineerprogrammer softwareengineerprogrammer deleted the royalty-economics branch October 5, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@softwareengineerprogrammer