Carbon Revenue Profile + Electricity annual revenue profile fix #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a result of apparent oversight in NREL@49ff3a1
…actoring in NREL@49ff3a1. Includes schema regeneration which removes CCUS-only parameters, switches construction years to surface plant category from economics.
…file. Has no effect on output since the values are the same as the default values.
…ray instead of multiple parameter names
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
changed the title
This was referenced Mar 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consists of 2 sub-prs, grouped together because they would create difficult-to-grok complexity/conflict issues if separated at this point.
SUB-PR 1: Carbon Revenue Profile (CCUS profile fix)
Diff: https://github.com/softwareengineerprogrammer/GEOPHIRES/pull/48/files/b7827193c46c9d4b0d7fbffab3800fb3bd83e163..f0cb15eb03f360f6c0cbdaf53410dee27acff684#diff-372dea2554a92733824c98709c9bdb5720c183c31762c3795bd3990f069a2f24
https://gtp.scientificwebservices.com/geophires?geophires-example-id=example1_addons
Follow-up issues:
SUB-PR 2: Electricity annual revenue profile fix
Diff/original PR: #49
Fix issue with revenue profile electricity annual revenue being erroneously replaced with total revenue (NREL#342)
Demonstration of fix for
Fervo_Project_Cape-3:Tangentially related follow-up fixes: