Skip to content

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Mar 7, 2025

See #55 instead (this PR closed/cancelled due to rebase)


Original description, see rebased PR for actual changes:

  1. Establishes/confirms parity with NREL manual NPV calculation re: NPV calculation differs from Excel/Google Sheets NREL/GEOPHIRES-X#344 (comment) - see https://github.com/softwareengineerprogrammer/GEOPHIRES/pull/53/files#diff-780d3d576fea7650243d4fdf0272c5ca5ed2d3751cd09fe0cca69fc1a59b21c8R40-R77
  2. Adds Cashflow Series Start Year (final name & documentation still pending as of the time of this writing) with default value = 0 (existing NPV calculation behavior) and option to provide value = 1 to use Excel-style NPV calculation. Added unit tests that establish parity between this method and Excel documentation NPV example.

@softwareengineerprogrammer
Copy link
Owner Author

softwareengineerprogrammer commented Mar 11, 2025

TODO

  1. verify this tracks with construction years other than 1 - mostly-enough-ishly addressed per Revenue Profile Period & Final Year Correction [v3.8.0] NREL/GEOPHIRES-X#359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant