Skip to content

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Mar 19, 2025

Description

Resolves NREL#338

Updated baseline correlations per NREL 2025 cost curve updates 1. Coefficients were shared with me by paper authors:

image

Updated well drilling cost correlation documentation to reference correlation sources (2025 cost curve update or GeoVision):
image

Testing & Validation

  1. Added unit test to check calibration of baseline curves with selected values from graphs in paper
  2. Regenerated affected examples and unit tests. Manually spot-checked to ensure regenerated results aligned with expectations.

Footnotes

  1. Akindipe, D. and Witter. E. 2025. "2025 Geothermal Drilling Cost Curves Update". https://pangea.stanford.edu/ERE/db/GeoConf/papers/SGW/2025/Akindipe.pdf?t=1740084555.

@softwareengineerprogrammer softwareengineerprogrammer changed the title 2025 Geothermal Drilling Cost Curves Update 2025 Geothermal Drilling Cost Curves Update [v3.8.5] Mar 19, 2025
@softwareengineerprogrammer softwareengineerprogrammer changed the title 2025 Geothermal Drilling Cost Curves Update [v3.8.5] 2025 Geothermal Drilling Cost Curves Update [v3.8.6] Mar 19, 2025

except (NotImplementedError, ValueError) as e:
raise ValueError(f'Input temperature & pressure ({Twater_degC}, {pressure}) '
f'are out of range or otherwise could not be used to calculate') from e
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in utils to water property exception messages are unrelated to drilling cost curves update

Comment on lines +1789 to 1805
# TODO this is displayed as "Project Net Revenue" in Revenue & Cashflow Profile which is probably not an
# accurate synonym for annual revenue
self.TotalRevenue = self.OutputParameterDict[self.TotalRevenue.Name] = OutputParameter(
Name="Annual Revenue from Project",
UnitType=Units.CURRENCYFREQUENCY,
PreferredUnits=CurrencyFrequencyUnit.MDOLLARSPERYEAR,
CurrentUnits=CurrencyFrequencyUnit.MDOLLARSPERYEAR
)

# TODO this is displayed as "Project Net Cashflow" in Revenue & Cashflow Profile which is probably not an
# accurate synonym for cumulative revenue
self.TotalCummRevenue = self.OutputParameterDict[self.TotalCummRevenue.Name] = OutputParameter(
Name="Cumulative Revenue from Project",
UnitType=Units.CURRENCY,
PreferredUnits=CurrencyUnit.MDOLLARS,
CurrentUnits=CurrencyUnit.MDOLLARS
)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Economics naming TODOs unrelated to main changes

@softwareengineerprogrammer softwareengineerprogrammer merged commit d14517d into main Mar 23, 2025
24 checks passed
@softwareengineerprogrammer softwareengineerprogrammer deleted the 2025-geothermal-drilling-cost-curves-update-2 branch March 31, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorporate NREL 2025 Geothermal Drilling Cost Curves Update

1 participant