forked from NREL/GEOPHIRES-X
-
Notifications
You must be signed in to change notification settings - Fork 1
2025 Geothermal Drilling Cost Curves Update [v3.8.6] #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
softwareengineerprogrammer
merged 16 commits into
main
from
2025-geothermal-drilling-cost-curves-update-2
Mar 23, 2025
Merged
2025 Geothermal Drilling Cost Curves Update [v3.8.6] #56
softwareengineerprogrammer
merged 16 commits into
main
from
2025-geothermal-drilling-cost-curves-update-2
Mar 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… curve value. Prep to add drilling cost curve citations to documentation
|
||
except (NotImplementedError, ValueError) as e: | ||
raise ValueError(f'Input temperature & pressure ({Twater_degC}, {pressure}) ' | ||
f'are out of range or otherwise could not be used to calculate') from e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in utils to water property exception messages are unrelated to drilling cost curves update
Comment on lines
+1789
to
1805
# TODO this is displayed as "Project Net Revenue" in Revenue & Cashflow Profile which is probably not an | ||
# accurate synonym for annual revenue | ||
self.TotalRevenue = self.OutputParameterDict[self.TotalRevenue.Name] = OutputParameter( | ||
Name="Annual Revenue from Project", | ||
UnitType=Units.CURRENCYFREQUENCY, | ||
PreferredUnits=CurrencyFrequencyUnit.MDOLLARSPERYEAR, | ||
CurrentUnits=CurrencyFrequencyUnit.MDOLLARSPERYEAR | ||
) | ||
|
||
# TODO this is displayed as "Project Net Cashflow" in Revenue & Cashflow Profile which is probably not an | ||
# accurate synonym for cumulative revenue | ||
self.TotalCummRevenue = self.OutputParameterDict[self.TotalCummRevenue.Name] = OutputParameter( | ||
Name="Cumulative Revenue from Project", | ||
UnitType=Units.CURRENCY, | ||
PreferredUnits=CurrencyUnit.MDOLLARS, | ||
CurrentUnits=CurrencyUnit.MDOLLARS | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Economics naming TODOs unrelated to main changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves NREL#338
Updated baseline correlations per NREL 2025 cost curve updates 1. Coefficients were shared with me by paper authors:
Updated well drilling cost correlation documentation to reference correlation sources (2025 cost curve update or GeoVision):

Testing & Validation
Footnotes
Akindipe, D. and Witter. E. 2025. "2025 Geothermal Drilling Cost Curves Update". https://pangea.stanford.edu/ERE/db/GeoConf/papers/SGW/2025/Akindipe.pdf?t=1740084555. ↩