Rich output code cordoning, HTML image fix #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing implementation of rich output is duplicative of Outputs.PrintOutputs. This adds undue code complexity, maintenance overhead, inconsistency, and potential for bugs. Rich output should instead be generated in a module that uses GeophiresXClient or an equivalent pattern which maintains Outputs.PrintOutputs as the ultimate source of truth/authority for output logic. (Somewhat conceptually tangentially relevant to NREL#9)
This change:
Testing & Validation
No unit tests were affected because no test coverage was added when rich output was implemented. A basic sanity-check test was added post-facto which ensures that a rich output HTML file is generated if specified in parameters and that it includes a case report header in expected format.
I looked at rich HTML output and noticed that images weren't included correctly, and a fix for that is included in this PR. Rich HTML output now appears as expected:
I briefly manually looked at rich text output in the console and it appeared as expected: