Helm & docker improvements #1561
Conversation
|
Ready for merge |
| OTEL_EXPORTER_OTLP_PROTOCOL: "{{ .Values.bootzooka.otel.protocol }}" | ||
| OTEL_SERVICE_NAME: "{{ .Values.bootzooka.otel.service_name }}" | ||
| OTEL_METRIC_EXPORT_INTERVAL: "{{ .Values.bootzooka.otel.metric_export_interval }}" | ||
| LOGBACK_JSON_ENCODE: "{{ .Values.bootzooka.logback_json_encode }}" |
There was a problem hiding this comment.
this doesn't seem to be used anywhere in the code, are you sure this does something? ;)
There was a problem hiding this comment.
@paapug this got merged, but is this setting needed?
| run: sbt docker/docker:publish | ||
| run: sbt 'set docker / version := "'${GITHUB_RUN_ID}'"' docker/docker:publish | ||
|
|
||
| deploy: |
There was a problem hiding this comment.
Not necessarily in scope, but I think this can be removed - we don't publish tag-based releases. It was a failed experiments some years ago
| needs: [verify] | ||
| runs-on: ubuntu-24.04 | ||
|
|
||
| if: github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
you don't need the github.event_name != 'pull_request' check? so that this doesn't run on PRs to master?
There was a problem hiding this comment.
It's enough, for pull requests the github.ref is set to refs/pull/<pr_number>/merge.
.github/workflows/bootzooka-ci.yml
Outdated
| version: "v${{ env.VERSION }}" | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: sbt 'set docker / version := "'${GITHUB_RUN_ID}'"' docker/docker:publish |
There was a problem hiding this comment.
so this will generate what kind of docker tags?
There was a problem hiding this comment.
softwaremill/bootzooka:16651072967, commit hash will be added as separate PR
There was a problem hiding this comment.
Update: added as a part of this PR
This PR:
GITHUB_RUN_IDoci://(https is no longer available)deployjob torelease(as it cerates a GH release)