Conversation
emil-bar
force-pushed
the
add-remaining-flow-methods
branch
from
fde5e59 to
d8455b8
Compare
emil-bar
force-pushed
the
add-remaining-flow-methods
branch
from
d8455b8 to
6695b7e
Compare
emil-bar
force-pushed
the
add-remaining-flow-methods
branch
from
6695b7e to
a2fcac9
Compare
adamw
reviewed
Jan 10, 2025
| } | ||
|
|
||
| @SafeVarargs | ||
| public final T flatten(T... args) { |
Member
There was a problem hiding this comment.
I think I'd add a comment here (apart from usual docs, which seem to be missing?), as to what's the purpose of the T... args - that it's just a technical way of checking generic type, not something the user should provide. Also in other places where we're using it. Otherwise people might get easily confused.
Contributor
Author
There was a problem hiding this comment.
Yeah, my bad I've missed the docs.
Added them now, with explanation that T... args is used only to verify type.
In getTClass function we also throw exception when array is not empty (Mockito does the same)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84