Merged
Conversation
Member
|
No remark, any formatting is good as long as it's consistent. Just two questions:
|
emil-bar
reviewed
Feb 3, 2025
channels/src/test/java/com/softwaremill/jox/ChannelInterruptionTest.java
Show resolved
Hide resolved
channels/src/test/java/com/softwaremill/jox/ChannelInterruptionTest.java
Show resolved
Hide resolved
flows/src/test/java/com/softwaremill/jox/flows/FlowFlattenTest.java
Outdated
Show resolved
Hide resolved
flows/src/test/java/com/softwaremill/jox/flows/FlowGroupedTest.java
Outdated
Show resolved
Hide resolved
Contributor
Maybe we can leave formatting style info relevant for us (like Java & xml) ? |
Contributor
Author
@emil-bar As I explained, cutting the |
Member
|
Ok, well you know my opinion, I'd just keep IJ defaults ;) |
Member
|
Thanks @Blef666 |
Contributor
Author
|
In the end I switched back to the default Intellij configuration except for the single line simple blocks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a unified code formatting. The configuration is stored in
.editorconfigfile so anyone can change it later. If you've got any subjective, estetical remarks, be welcome to share them, I'll consider involving them.Currently there is no possibility of creating solution consisting of both automatic code formatting in IDE and CI pipeline validation. I limited it to only IDE formatting.