Skip to content

Conversation

@Blef666
Copy link
Contributor

@Blef666 Blef666 commented Feb 20, 2025

No description provided.

@Blef666 Blef666 requested a review from adamw February 20, 2025 10:26
@adamw
Copy link
Member

adamw commented Feb 20, 2025

Where does actions/upload-artifact come from?

@Blef666
Copy link
Contributor Author

Blef666 commented Mar 4, 2025

@adamw actions/upload-artifact with test results upload step used to be in ox and sttp-openai after the CI build.

@adamw
Copy link
Member

adamw commented Mar 4, 2025

@Blef666 ah so it's now in the common definition? but this doesn't explain the error anyway?

@Blef666
Copy link
Contributor Author

Blef666 commented Mar 4, 2025

@adamw It might be. There is a test artifact generated with name tests-results and since in this workflow we use matrix strategy to build the project with multiple java versions, these artifacts create name conflict. I'll change the reusable workflow so that each test result was called tests-results-java-X and X will be taken from the input param.

@Blef666
Copy link
Contributor Author

Blef666 commented Mar 5, 2025

@adamw It seems to work now.

@adamw adamw merged commit cb1977e into master Mar 5, 2025
10 checks passed
@adamw adamw deleted the refactor_github_actions_workflows branch March 5, 2025 15:28
@adamw
Copy link
Member

adamw commented Mar 5, 2025

Indeed, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants