Skip to content

Optimize cancellable fork when it's cancelled before starting #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamw merged 1 commit into from
Jun 24, 2025
Merged

Optimize cancellable fork when it's cancelled before starting #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/ox/fork.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import java.util.concurrent.Semaphore
import java.util.concurrent.atomic.AtomicBoolean
import scala.concurrent.ExecutionException
import scala.util.control.NonFatal
import scala.util.control.NoStackTrace

/** Starts a fork (logical thread of execution), which is guaranteed to complete before the enclosing [[supervised]] or [[supervisedError]]
* block completes.
Expand Down Expand Up @@ -199,7 +200,9 @@ def forkCancellable[T](f: => T)(using OxUnsupervised): CancellableFork[T] =
// will cause the scope to end, interrupting the task if it hasn't yet finished (or potentially never starting it)
done.release()
if !started.getAndSet(true)
then result.completeExceptionally(new InterruptedException("fork was cancelled before it started")).discard
then result.completeExceptionally(new InterruptedException("fork was cancelled before it started") with NoStackTrace).discard
// #161: not generating the stack trace in case the task was cancelled before it started, as this isn't going to
// contain any useful information anyway (no user code was executed), and it provides better performance
end new
end forkCancellable

Expand Down