Fix data race in Flow.groupBy #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
added a commit
to softwaremill/jox
that referenced
this pull request
Sep 24, 2025
Port of the data race fix from Ox project (softwaremill/ox#346). The original implementation used separate channels for child outputs and completion signals, which could lead to race conditions. This change unifies them into a single channel using a sealed interface hierarchy, eliminating the race condition. Changes: - Replace separate childOutput and childDone channels with unified ChildOutput channel - Introduce ChildOutput sealed interface with ChildValue and ChildDone implementations - Update channel selection logic to handle unified output channel - Add stress test to validate the fix (100k iterations) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
adamw
added a commit
to softwaremill/jox
that referenced
this pull request
Sep 24, 2025
Port of the data race fix from Ox project (softwaremill/ox#346). The original implementation used separate channels for child outputs and completion signals, which could lead to race conditions. This change unifies them into a single channel using a sealed interface hierarchy, eliminating the race condition. Changes: - Replace separate childOutput and childDone channels with unified ChildOutput channel - Introduce ChildOutput sealed interface with ChildValue and ChildDone implementations - Update channel selection logic to handle unified output channel - Add stress test to validate the fix (100k iterations) 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.