Skip to content

MPT-18371 mark helpdesk chat tests as flaky#235

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-18371
Mar 17, 2026
Merged

MPT-18371 mark helpdesk chat tests as flaky#235
jentyk merged 1 commit intomainfrom
feat/MPT-18371

Conversation

@jentyk
Copy link
Contributor

@jentyk jentyk commented Mar 17, 2026

Closes MPT-18371

  • Mark all tests in tests/e2e/helpdesk/chats/test_async_chats.py as flaky by adding module-level pytest.mark.flaky marker
  • Mark all tests in tests/e2e/helpdesk/chats/test_sync_chats.py as flaky by adding module-level pytest.mark.flaky marker

@jentyk jentyk requested a review from a team as a code owner March 17, 2026 17:00
@jentyk jentyk requested review from albertsola and robcsegal March 17, 2026 17:00
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3844f536-44ad-45d7-882a-6540ba89e7fd

📥 Commits

Reviewing files that changed from the base of the PR and between a2d90ec and b0004b4.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/test_async_chats.py
  • tests/e2e/helpdesk/chats/test_sync_chats.py

📝 Walkthrough

Walkthrough

Module-level flaky markers are added to two test files in the e2e helpdesk chats test suite. These changes designate all tests in each module as flaky using pytest's mark.flaky mechanism, requiring no modifications to existing test logic or assertions.

Changes

Cohort / File(s) Summary
Test Flaky Markers
tests/e2e/helpdesk/chats/test_async_chats.py, tests/e2e/helpdesk/chats/test_sync_chats.py
Add module-level pytestmark = [pytest.mark.flaky] to mark all tests in each module as flaky for pytest handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the correct format MPT-18371.
Test Coverage Required ✅ Passed The PR exclusively modifies test files within the tests/ folder by adding pytest flaky markers. No production code files in the mpt_api_client/ directory are modified.
Single Commit Required ✅ Passed The PR contains exactly one commit (b0004b4) that adds pytest.mark.flaky marker to both test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@sonarqubecloud
Copy link

@jentyk jentyk merged commit b3df508 into main Mar 17, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-18371 branch March 17, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants