MPT-17299: add status column to the list command#30
Merged
svazquezco merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
📝 WalkthroughWalkthroughAdds a migration status enum and list-item dataclass, changes listing use-case to return typed items, replaces table renderer with a Rich-aware MigrationRender class, updates run logic to persist status transitions, adds CONSOLE_WIDTH, and updates docs/tests to show a new status column. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
2018010 to
4ff912f
Compare
4ff912f to
d0ece9e
Compare
d0ece9e to
110289f
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@mpt_tool/renders.py`:
- Line 15: Remove the unnecessary "# noqa: PLW3201" directive from the
__rich_console__ method signature (def __rich_console__(self, console: Console,
options: ConsoleOptions) -> RenderResult) since PLW3201 is not enforced by our
linters; simply delete the trailing noqa comment so the method signature is
clean.
In `@mpt_tool/use_cases/run_migrations.py`:
- Around line 52-55: Currently the code calls self._save_state(state,
status=MigrationStatusEnum.RUNNING) before executing migration_instance.run(),
which can leave migrations stuck as STARTED after a crash; remove or move that
pre-run persistence so you do not persist RUNNING before execution — instead
call self._save_state(...) with MigrationStatusEnum.RUNNING only after run() has
successfully started/finished as appropriate, or persist only immutable pre-run
metadata and persist RUNNING in the success path; update the block around
logger.info, self._save_state, and migration_instance.run() to ensure RUNNING is
not written prior to calling migration_instance.run().
albertsola
approved these changes
Feb 3, 2026
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add status column to the list command
Closes MPT-17299