You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds pre-commit hook configuration and documentation for running migration checks. Introduces .pre-commit-hooks.yaml with a migration validation hook and updates README with setup instructions.
Added new pre-commit hook configuration file defining a "Check migrations" hook that runs mpt-service-cli migrate --check on Python migration files. Updated README with Pre-commit section containing setup instructions and YAML configuration snippet for integrating the migration check hook.
Found Jira issue key in the title: MPT-17672. The PR title correctly includes exactly one Jira issue key in the required format MPT-XXXX.
Test Coverage Required
✅ Passed
PR modifies only configuration and documentation files (.pre-commit-hooks.yaml, README.md), not source code files requiring test coverage.
Single Commit Required
✅ Passed
The PR contains exactly one commit, which maintains a clean git history.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
No actionable comments were generated in the recent review. 🎉
🧹 Recent nitpick comments
README.md (1)
63-74: Documentation looks good, minor suggestion for completeness.
The pre-commit configuration example is clear and correctly references the check-migrations hook. Consider adding a brief note explaining that the hook validates migration files for duplicate migration_id values, so users understand what the hook does before adding it to their config.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MPT-17672
.pre-commit-hooks.yamlconfiguration file with acheck-migrationshook that validates migration files for duplicate migration IDs