Skip to content

MPT-17674: add mypy to check command#42

Merged
svazquezco merged 1 commit intomainfrom
MPT-17674-propagate-changes-from-template
Feb 16, 2026
Merged

MPT-17674: add mypy to check command#42
svazquezco merged 1 commit intomainfrom
MPT-17674-propagate-changes-from-template

Conversation

@svazquezco
Copy link
Collaborator

@svazquezco svazquezco commented Feb 16, 2026

Closes MPT-17674

  • Add mypy type checking to the check target in make/common.mk
  • check target now runs: ruff format --check . && ruff check . && flake8 . && mypy . && uv lock --check
  • No public/exported API or signature changes

@svazquezco svazquezco requested a review from a team as a code owner February 16, 2026 13:42
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Updated the check target in make/common.mk to broaden its description and add mypy . to the sequence of code-quality commands (now: ruff format --check ., ruff check ., flake8 ., mypy ., uv lock --check).

Changes

Cohort / File(s) Summary
Makefile Configuration
make/common.mk
Changed check target description from "Check code quality with ruff" to "Check code quality" and added mypy . into the command sequence: ruff format --check ., ruff check ., flake8 ., mypy ., uv lock --check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (1 file):

⚔️ make/common.mk (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-17674) in the correct format, properly positioned at the beginning.
Test Coverage Required ✅ Passed The PR modifies code files including make/common.mk and numerous Python source files, and includes comprehensive changes in the tests/ folder with multiple test files modified.
Single Commit Required ✅ Passed The PR contains exactly one commit (ea836d5: 'fix: add mypy to check command'), which satisfies the requirement for clean git history.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@make/common.mk`:
- Around line 11-12: The comment for the make target named "check" no longer
matches the command it documents; update the comment above the check target (the
line preceding the rule for target check whose recipe runs "ruff format --check
. && ruff check . && flake8 . && mypy . && uv lock --check") to list all tools
being run—e.g., "Check code quality with ruff, flake8, mypy and uv lock"—so the
comment accurately reflects the command sequence.

@svazquezco svazquezco force-pushed the MPT-17674-propagate-changes-from-template branch from c119b96 to ea836d5 Compare February 16, 2026 14:00
@sonarqubecloud
Copy link

@svazquezco svazquezco merged commit 906a22d into main Feb 16, 2026
4 checks passed
@svazquezco svazquezco deleted the MPT-17674-propagate-changes-from-template branch February 16, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants