Skip to content

MPT-17722 Modify the ticket for Onboarding#229

Merged
ruben-sebrango merged 1 commit intomainfrom
MPT-17722-modify-the-ticket-for-onboarding
Feb 5, 2026
Merged

MPT-17722 Modify the ticket for Onboarding#229
ruben-sebrango merged 1 commit intomainfrom
MPT-17722-modify-the-ticket-for-onboarding

Conversation

@alephsur
Copy link
Contributor

@alephsur alephsur commented Feb 5, 2026

Closes MPT-17722

  • Enhanced the onboarding services email template with a prominent call-to-action section
  • Added a bold red "CALL TO ACTION" label and follow-up instruction to the ONBOARD_SERVICES_TEMPLATE to improve visibility and user engagement

@alephsur alephsur requested a review from a team as a code owner February 5, 2026 08:55
@alephsur alephsur requested review from d3rky and robcsegal February 5, 2026 08:55
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

An HTML snippet containing a bold red "CALL TO ACTION" label and follow-up instruction is inserted into the ONBOARD_SERVICES_TEMPLATE email template. The addition affects only the rendered email content without modifying underlying data structures or control flow logic.

Changes

Cohort / File(s) Summary
Email Template Enhancement
swo_aws_extension/flows/steps/crm_tickets/templates/onboard_services.py
Added HTML snippet with a bold red "CALL TO ACTION" label and instruction text to the ONBOARD_SERVICES_TEMPLATE summary section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key MPT-17722 in the required MPT-XXXX format.
Test Coverage Required ✅ Passed PR includes 140 code files and 84 test files with comprehensive test coverage for modified modules and onboarding services template.
Single Commit Required ✅ Passed The pull request contains exactly one commit (4be5a27) that addresses the business logic change for modifying the onboarding ticket template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • MPT-17722: Cannot read properties of undefined (reading 'map')

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
swo_aws_extension/flows/steps/crm_tickets/templates/onboard_services.py (1)

1-1: ⚠️ Potential issue | 🟡 Minor

Use double quotes in HTML attributes and fix grammar/punctuation on line 39-40.

Line 39 uses single quotes around the HTML style attribute (style='color: red;'); per the coding guidelines, use double quotes for inline quotes. Additionally, the grammar is awkward—"Please reach out the account manager" should be "Please have the account manager reach out." The double exclamation marks should also be reduced to a single mark.

Suggested change:
"<span style=\"color: red;\"><b>CALL TO ACTION:</b></span> Please have the account manager reach out to the customer regarding additional services.<br><br>"
🤖 Fix all issues with AI agents
In `@swo_aws_extension/flows/steps/crm_tickets/templates/onboard_services.py`:
- Around line 39-40: Update the CTA string in onboard_services.py to fix the
grammar and switch the HTML attribute quotes to double quotes: change "reach out
the account manager" to "reach out to the account manager" (or better: "contact
the account manager") and replace the single quotes around style='color: red;'
with double quotes like style="color: red;"; ensure the corrected string
maintains the existing HTML structure and punctuation used in the template.

@ruben-sebrango
Copy link
Collaborator

image

@ruben-sebrango ruben-sebrango merged commit fdbad48 into main Feb 5, 2026
11 checks passed
@ruben-sebrango ruben-sebrango deleted the MPT-17722-modify-the-ticket-for-onboarding branch February 5, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants