Skip to content

[Snyk] Upgrade @onflow/types from 1.4.1 to 1.4.2 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade @onflow/types from 1.4.1 to 1.4.2 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 43 additions & 4 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"dependencies": {
"@onflow/fcl": "1.20.0",
"@onflow/types": "1.4.1",
"@onflow/types": "1.4.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request introduces a second version of the @onflow/types package into the project's dependencies.

While the root dependency is updated to 1.4.2, other packages like @onflow/fcl, @onflow/fcl-core, and @onflow/sdk still depend on version 1.4.1. This can be seen in the package-lock.json changes, where 1.4.1 is being added as a nested dependency.

Having multiple versions of the same package can lead to:

  • Increased bundle size.
  • Potential subtle bugs if the different versions are not fully compatible or if the package relies on singletons.

To resolve this, I recommend one of the following approaches:

  1. Update related @onflow packages: Check if newer versions of @onflow/fcl, @onflow/fcl-core, and @onflow/sdk are available that depend on @onflow/types@^1.4.2. This is the cleanest solution.
  2. Use overrides: If you are using npm v8+ or Yarn, you can use overrides (npm) or resolutions (Yarn) in your package.json to enforce a single version of @onflow/types. For example (for npm): 
    "overrides": {
  "@onflow/types": "1.4.2"
}
    If you are on an older npm version, you might need to use a tool like npm-force-resolutions.

This will ensure that only one version of @onflow/types is used throughout the project, leading to a more stable and smaller build.

"@testing-library/jest-dom": "^6.8.0",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.6.1",
Expand Down
Loading