Skip to content

refactor: remove daily energy sensor#136

Draft
CFenner wants to merge 2 commits intosolakon-de:mainfrom
CFenner:daily
Draft

refactor: remove daily energy sensor#136
CFenner wants to merge 2 commits intosolakon-de:mainfrom
CFenner:daily

Conversation

@CFenner
Copy link
Collaborator

@CFenner CFenner commented Dec 19, 2025

The daily energy sensor is not aligned with the users time. Therefore ideally it is better to use the total energy sensor and if necessary create a helper with daily reset.

fixes #104

@gemini-code-assist
Copy link

Summary of Changes

Hello @CFenner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the solakon_one integration by removing the daily_generation energy sensor. The rationale behind this removal is that the sensor did not align correctly with user time, and it is recommended that users instead utilize the cumulative_generation sensor, creating a helper with daily reset functionality if specific daily energy tracking is required. This change simplifies the sensor offerings and addresses a potential inconsistency.

Highlights

  • Sensor Removal: The daily_generation energy sensor has been completely removed from the integration.
  • Configuration Update: The constant definition for daily_generation was removed from const.py.
  • Translation Cleanup: Associated translations for the daily_generation sensor were removed from both German (de.json) and English (en.json) language files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the daily_generation sensor, which was not functioning correctly due to timezone misalignment. The changes involve removing the sensor's definition from the Modbus register map, its entity description, and its translations in both English and German. The removals are clean and consistent across all modified files. The code is correct and this change resolves the underlying issue as described. I have no further suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily energy usage is not following my timezone

1 participant