Skip to content

Add basics/hello-solana/steel #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Add basics/hello-solana/steel #146

wants to merge 10 commits into from

Conversation

@Perelyn-sama
Copy link
Collaborator

@Perelyn-sama Perelyn-sama commented Oct 19, 2024

No description provided.

@Perelyn-sama Perelyn-sama changed the title add hello solana steel example Add tokens/hello-solana/steel Oct 23, 2024
@Perelyn-sama Perelyn-sama changed the title Add tokens/hello-solana/steel Add basics/hello-solana/steel Oct 23, 2024
@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Oct 24, 2024

weird, I'll do a re-run

@Perelyn-sama Perelyn-sama force-pushed the steel/hello-solana branch 2 times, most recently from fb18f6d to 329a206 Compare October 26, 2024 21:07
@Perelyn-sama
add hello solana steel example and add bankrun test
6464015 
add hello solana steel example

fix syntax issue in steel hello world example

add backrun tests

fix tests issue

correct program and api name

fixed typo in test.rs and updated steel version
@heyAyushh heyAyushh added the contribute:steel Adds program example using steel framework. label Nov 5, 2024
@heyAyushh
Copy link
Member

heyAyushh commented Nov 5, 2024 •
edited
Loading

@Perelyn-sama please fix the workspace issues,

https://github.com/solana-developers/program-examples/blob/main/CONTRIBUTING.md#general-coding-and-writing-guidelines
Also lint the files by changing directory to the root of program examples.

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 5, 2024

Alright, on it 🫡

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 5, 2024

this issue is so weird, it works fine on my mac but pops up here. Thankfully I was able to recreate it on my windows

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 6, 2024

btw, this command is not in the root package.json

Screenshot 2024-11-06 144731

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 7, 2024

lmao

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 7, 2024

so I had to re-organise the project. I didn't want to remove api so I turned it to a mod inside program.

I also had to remove solana-program-test because it was causing some errors.

I think I'll try implementing the tests in litesvm because Rust tests are very IMPORTANT!

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 7, 2024

Hey @heyAyushh I made this https://github.com/Perelyn-sama/solana-program-examples-scripts/tree/main to help improve the review process for everyone

@Perelyn-sama
Copy link
Collaborator Author

Perelyn-sama commented Nov 14, 2024

@heyAyushh third week's the charm?

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@heyAyushh heyAyushh

@jacobcreech jacobcreech

Labels

contribute:steel Adds program example using steel framework.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Perelyn-sama @heyAyushh @jacobcreech