Skip to content

Conversation

@Nitish-bot
Copy link
Contributor

@Nitish-bot Nitish-bot commented Oct 28, 2024

Added example program for creating an account with the Steel framework for Solana

  • Committed pnpm-lock.yaml
  • Tests written in bankrun
  • Added mandatory pnpm run scripts
  • Ran pnpm fix in the root directory
  • Added "cicd.sh"
  • Wrote a small README
  • Wrote comments to guide
  • Used latest versions of all dependencies*

*Note: I could not use the latest version of 'Chai' since they have dropped support for commonjs from v5 onward.

image

@heyAyushh heyAyushh added contribute:steel Adds program example using steel framework. create-account basics/create-account labels Nov 6, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@Nitish-bot
Copy link
Contributor Author

Nitish-bot commented Nov 24, 2024

Hey I have done all of these but I went ahead and tried to redo all of them but pnpm fix did not work and instead threw this error. I tried deleting my .cache folder as well.
Regardless, I had run pnpm fix when I initially committed these changes and it worked fine then.

Also my tests are in typescript using solana bankrun and I have not used steel tests, should I do that?
image

Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM no issues

@heyAyushh heyAyushh merged commit 3c74f3b into solana-developers:main Jan 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribute:steel Adds program example using steel framework. create-account basics/create-account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants