Skip to content

Conversation

@ritikbhatt20
Copy link
Contributor

@ritikbhatt20 ritikbhatt20 commented Oct 29, 2024

Key Differences from previous spl-token-minter PR:

replaced all occurrences of yarn with pnpm to maintain consistency across the project.

executed pnpm fix to ensure code quality.

committed the pnpm-lock.yaml file to the repository.

Screenshot (574)

@heyAyushh heyAyushh added the contribute:poseidon Adds a poseidon example contribution to the repository. label Nov 15, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@ritikbhatt20 ritikbhatt20 force-pushed the spl-token-minter/poseidon branch from 33a9f57 to c4a1126 Compare November 26, 2024 03:02
@ritikbhatt20
Copy link
Contributor Author

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates

  2. Run pnpm fix at the project root for consistent code style

  3. Ensure your implementation includes:

    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys

  5. Run cargo fmt and cargo clippy for Rust code quality

  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

gm @heyAyushh ,

I've completed the requested steps:

  1. Merged main into my branch.
  2. Ran pnpm fix.
  3. Verified the implementation includes the transpiled Anchor program and TypeScript files.
  4. Synchronized program ID
  5. Ran cargo fmt and cargo clippy for Rust code quality.
  6. Pushed all updates.

Please review again. Thank you!

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribute:poseidon Adds a poseidon example contribution to the repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants