Pascal case for Enums, calculator program + Modified Hello program#12
Open
lostintime101 wants to merge 5 commits intosolana-developers:mainfrom
Open
Pascal case for Enums, calculator program + Modified Hello program#12lostintime101 wants to merge 5 commits intosolana-developers:mainfrom
lostintime101 wants to merge 5 commits intosolana-developers:mainfrom
Conversation
Updated the Calculator example program Enums to Pascal case due to an issue on Playgrounds. See: solana-playground/solana-playground#191
Author
|
Have modified the "Hello" program, adding a missing instruction to create the user token account |
mcintyre94
requested changes
Mar 5, 2024
Collaborator
mcintyre94
left a comment
There was a problem hiding this comment.
Looks good! Would you mind updating the generated examples too? If you have the repo running locally you should be able to just run ./tests/compile-tests.sh. Then check in the updated files.
Author
Collaborator
|
Ah sorry, if you run The idea of that script is that if we change the compiler code, we can re-compile a bunch of code and verify that the output either isn't changed, or is changed in the expected way. So it runs against the locally compiled version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator example program Enums changed to Pascal case due to an issue on Playgrounds.
See: solana-playground/solana-playground#191