Open
Conversation
tldr: rustfmt doesn't handle stuff inside annotations well so we manually patch some spacing issues, mainly turning account stuff like this: ```rust ``` into ```rust ```
mcintyre94
reviewed
Dec 4, 2024
Collaborator
mcintyre94
left a comment
There was a problem hiding this comment.
Thanks for this! I'm a bit hesitant about adding our own formatting stuff instead of just throwing it to rustfmt. Is rustfmt not formatting the current output sensibly?
Author
unfortunately not. what rustfmt gets is a stream of tokens which lack whitespace info, and rusfmt produces really ugly output in annotations specifically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr: rustfmt doesn't handle stuff inside annotations well so we manually patch some spacing issues, mainly turning account stuff like this:
# [account (init , space = std :: mem :: size_of :: < dot :: program :: Calculator > () + 8 , payer = owner , seeds = ["Calculator" . as_bytes () . as_ref () , owner . key () . as_ref ()] , bump)]into
#[account(init, space = std::mem::size_of::<dot::program::Calculator>() + 8, payer = owner, seeds = ["Calculator".as_bytes().as_ref(), owner.key().as_ref()], bump)]Also, convert /// CHECK comments back to that format
Overall goal is to make the generated source easier to examine and more familiar by sticking to what Anchor usually looks like