Remove deceptive unknown #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooncitydev
reviewed
Apr 23, 2025
mooncitydev
left a comment
mooncitydev
left a comment
There was a problem hiding this comment.
This was so much of a distraction for me that, wow, I've distracted myself further by making this PR.
The word, "unknown" in this message is at best unneeded and at worst deceptive. The error is almost certainly known. It was passed to the catch. We could figure it out. We could code to it. What we're doing is punting, because writing a bunch of error detecting code would be a distraction here. So, let's be honest about it. An error occurred. It is not unknown. We're simply punting it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was so much of a distraction for me that, wow, I've distracted myself further by making this PR.
The word, "unknown" in this message is at best unneeded and at worst deceptive. The error is almost certainly known. It was passed to the catch. We could figure it out. We could code to it. What we're doing is punting, because writing a bunch of error detecting code would be a distraction here. So, let's be honest about it. An error occurred. It is not unknown. We're simply punting it out.