Point at client only with reason #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooncitydev
reviewed
Apr 23, 2025
mooncitydev
left a comment
mooncitydev
left a comment
There was a problem hiding this comment.
why from 400 to 500 error
whats for 404 error
Author
|
400 is bad request "indicates that the server would not process the request due to something the server considered to be a client error." 404 is not found "indicates that the server cannot find the requested resource." 500 is internal server error "indicates that the server encountered an unexpected condition that prevented it from fulfilling the request." PR causes 500 in place of 400 if the cause is not an identified problem with the request. |
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's be friendly and helpful. Let's not point at the client without reason.
Here we return 400 provided we've examined the request, found fault, and thrown a message. Otherwise, we are honest, friendly and credible. Not having examined the fault, we accept responsibility using 500.