Skip to content

v0.32.0#3955

Closed
jacobcreech wants to merge 5 commits intosolana-foundation:masterfrom
jacobcreech:0.32.0
Closed

v0.32.0#3955
jacobcreech wants to merge 5 commits intosolana-foundation:masterfrom
jacobcreech:0.32.0

Conversation

@jacobcreech
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 27, 2025

@jacobcreech is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@jacobcreech jacobcreech force-pushed the 0.32.0 branch 2 times, most recently from 2bb1eda to 8a1aa30 Compare October 1, 2025 05:31
Comment on lines +19 to +27
## [0.32.0] - 2025-10-01

### Features

### Fixes

### Breaking

## [0.32.0] - 2025-10-01
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bump-version script has been run twice, which ended up adding double entry here.


| Program | Binary Size | - |
| ------- | ----------- | ---------------------- |
| bench | 1,127,424 | 🔴 **+85,496 (8.21%)** |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a binary size change in a version bump PR doesn't make sense and should never happen. CI would have failed in previous PRs if this was the case. Make sure your active Solana tooling version matches the "Solana version".

If you want to change the Solana version, that should ideally be done in a separate PR (e.g. #3339) because upgrading Solana tooling version might require additional code changes, which would go against the nature of our own version bump PRs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like there was a regression too. We'll have to do a separate pr for the update then this one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, there shouldn't be CU changes from 0.32.0 to Unreleased.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR branch is not up to date with master (24 commits behind). This may cause unexpected behavior, such as conflicts and CI passing now but failing after merging to master.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to bump mollusk-svm to 0.5 since that's the latest Solana v2 compatible version:

mollusk-svm = "~0.4"

Comment on lines +516 to +547
"@coral-xyz/anchor-errors@^0.31.1":
version "0.31.1"
resolved "https://registry.yarnpkg.com/@coral-xyz/anchor-errors/-/anchor-errors-0.31.1.tgz#d635cbac2533973ae6bfb5d3ba1de89ce5aece2d"
integrity sha512-NhNEku4F3zzUSBtrYz84FzYWm48+9OvmT1Hhnwr6GnPQry2dsEqH/ti/7ASjjpoFTWRnPXrjAIT1qM6Isop+LQ==

"@coral-xyz/anchor@=0.31.1":
version "0.31.1"
resolved "https://registry.yarnpkg.com/@coral-xyz/anchor/-/anchor-0.31.1.tgz#0fdeebf45a3cb2e47e8ebbb815ca98542152962c"
integrity sha512-QUqpoEK+gi2S6nlYc2atgT2r41TT3caWr/cPUEL8n8Md9437trZ68STknq897b82p5mW0XrTBNOzRbmIRJtfsA==
dependencies:
"@coral-xyz/anchor-errors" "^0.31.1"
"@coral-xyz/borsh" "^0.31.1"
"@noble/hashes" "^1.3.1"
"@solana/web3.js" "^1.69.0"
bn.js "^5.1.2"
bs58 "^4.0.1"
buffer-layout "^1.2.2"
camelcase "^6.3.0"
cross-fetch "^3.1.5"
eventemitter3 "^4.0.7"
pako "^2.0.3"
superstruct "^0.15.4"
toml "^3.0.0"

"@coral-xyz/borsh@^0.31.1":
version "0.31.1"
resolved "https://registry.yarnpkg.com/@coral-xyz/borsh/-/borsh-0.31.1.tgz#5328e1e0921b75d7f4a62dd3f61885a938bc7241"
integrity sha512-9N8AU9F0ubriKfNE3g1WF0/4dtlGXoBN/hd1PvbNBamBNwRgHxH4P+o3Zt7rSEloW1HUs6LfZEchlx9fW7POYw==
dependencies:
bn.js "^5.1.2"
buffer-layout "^1.2.0"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect — we don't want to use the published versions (especially older ones). It should work as expected after you successfully link the local packages either manually or by using the setup-tests script.

@jacobcreech jacobcreech closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants