Skip to content

refactor: clean up init script utils#144

Merged
beeman merged 1 commit intomainfrom
beeman/refactor-init-scripts
Jun 16, 2025
Merged

refactor: clean up init script utils#144
beeman merged 1 commit intomainfrom
beeman/refactor-init-scripts

Conversation

@beeman
Copy link
Collaborator

@beeman beeman commented Jun 7, 2025

No description provided.

@beeman beeman force-pushed the beeman/refactor-init-scripts branch from 250917c to 82c4cda Compare June 14, 2025 19:25
@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2025

🦋 Changeset detected

Latest commit: 813773d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-dapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@beeman beeman force-pushed the beeman/refactor-init-scripts branch 11 times, most recently from 1370e86 to 1d29180 Compare June 15, 2025 01:49
Copy link
Collaborator Author

@beeman beeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly mechanical refactor of the init scripts and some more tests.

@tobeycodes requested a review to see if anything weird stands out. I don't think there's need to go through everything with a fine-tooth comb though.


export const initScriptKey = 'create-solana-dapp'

export function getInitScript(targetDirectory: string): InitScript | undefined {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out we no longer needed this now that getPackageJson parses it.

@beeman beeman requested a review from tobeycodes June 15, 2025 02:22
@beeman beeman force-pushed the beeman/refactor-init-scripts branch 2 times, most recently from 4c3df49 to 0a2a3d0 Compare June 15, 2025 02:39
@beeman beeman force-pushed the beeman/refactor-init-scripts branch from 0a2a3d0 to 813773d Compare June 16, 2025 10:57
@beeman beeman merged commit 813773d into main Jun 16, 2025
64 checks passed
@beeman beeman deleted the beeman/refactor-init-scripts branch June 16, 2025 12:50
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants