Skip to content

Clarify that SIMD-0392 balance checking semantics apply to fee/commission distribution#466

Open
igor56D wants to merge 2 commits intosolana-foundation:mainfrom
igor56D:clarify-0392-fee-distribution
Open

Clarify that SIMD-0392 balance checking semantics apply to fee/commission distribution#466
igor56D wants to merge 2 commits intosolana-foundation:mainfrom
igor56D:clarify-0392-fee-distribution

Conversation

@igor56D
Copy link
Contributor

@igor56D igor56D commented Feb 10, 2026

Fee/Commission distribution is subject to RentState transition checks just like write-locked accounts are so the same semantics need to be enforced there.

@simd-bot
Copy link

simd-bot bot commented Feb 10, 2026

Hello igor56D! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here.

This PR requires the following approvals before it can be merged:

Once all requirements are met, you can merge this PR by commenting /merge.

Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you update it to say "commission" instead of "fee"? That way, it covers the existing fee-based distribution as well as the upcoming commission-based block revenue distribution.
anza-xyz/agave#9380 (review)

You can maybe add a tiny paragraph that mentions this applies to the current fee distribution as well as the next version of commission distribution where fees are distributed via block revenue commission (SIMD-0123).

@igor56D igor56D changed the title Clarify that SIMD-0392 balance checking semantics apply to fee distribution Clarify that SIMD-0392 balance checking semantics apply to fee/commission distribution Feb 11, 2026
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for adding!

@igor56D
Copy link
Contributor Author

igor56D commented Feb 12, 2026

Can I get approvals on this @bw-solana @topointon-jump? very small change

@simd-bot
Copy link

simd-bot bot commented Feb 12, 2026

Thanks, bw-solana!

⚠️ Status: Cannot merge yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants