Clarify that SIMD-0392 balance checking semantics apply to fee/commission distribution#466
Clarify that SIMD-0392 balance checking semantics apply to fee/commission distribution#466igor56D wants to merge 2 commits intosolana-foundation:mainfrom
Conversation
…on as well as transaction execution
|
Hello igor56D! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here. This PR requires the following approvals before it can be merged:
Once all requirements are met, you can merge this PR by commenting |
There was a problem hiding this comment.
Looks good, but can you update it to say "commission" instead of "fee"? That way, it covers the existing fee-based distribution as well as the upcoming commission-based block revenue distribution.
anza-xyz/agave#9380 (review)
You can maybe add a tiny paragraph that mentions this applies to the current fee distribution as well as the next version of commission distribution where fees are distributed via block revenue commission (SIMD-0123).
buffalojoec
left a comment
There was a problem hiding this comment.
Lgtm, thanks for adding!
|
Can I get approvals on this @bw-solana @topointon-jump? very small change |
|
Thanks, bw-solana!
|
Fee/Commission distribution is subject to RentState transition checks just like write-locked accounts are so the same semantics need to be enforced there.