This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-2022: adjust PodAccount initialized check
#6953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
commented
Jun 30, 2024
Comment on lines
+1739
to
+1749
| // input buffer invalid | ||
| // all 5's - not a valid `AccountState` | ||
| let mut buffer = vec![5; BASE_ACCOUNT_LENGTH]; | ||
| assert_eq!( | ||
| PodStateWithExtensions::<PodAccount>::unpack(&buffer), | ||
| Err(ProgramError::UninitializedAccount) | ||
| ); | ||
| assert_eq!( | ||
| PodStateWithExtensionsMut::<PodAccount>::unpack(&mut buffer), | ||
| Err(ProgramError::UninitializedAccount) | ||
| ); |
There was a problem hiding this comment.
This test case targets the exact problem.
joncinque
approved these changes
Jul 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The method to determine if a particular
PodAccountis initialized simply checkswhether or not the
statefield (AccountState) is not equal to zero.However, this means that any number besides
0is considered to be an initializedPodAccount. This allows arbitrary data with size 165 to be considered a valid tokenaccount. For example,
&[5; 165]registers as an initialized token account.Summary of Changes
Adjust the
is_initializedmethod to explicitly check the two initializedAccountStatevariants, rather than
!= 0.