This repository was archived by the owner on Mar 11, 2025. It is now read-only.
[confidential-transfer] Organize transfer proof data using structs #7021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
split-proof-struct
branch
from
29803eb to
468c967
Compare
joncinque
previously approved these changes
Jul 17, 2024
samkim-crypto
force-pushed
the
split-proof-struct
branch
from
468c967 to
2efecac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The constructor functions for proof data required for confidential transfer and transfer with fee returns a tuple of proof data structs. It would be cleaner and more readable to organize the return type using structs instead.
Summary of changes
Re-organize the proof data using structs.