This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Adding Curve Option When Creating ATA #7143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
previously requested changes
Aug 15, 2024
mergify
bot
dismissed
buffalojoec’s stale review
Pull request has been modified.
Thank you, I just updated it; please check! |
buffalojoec
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In certain scenarios, such as with a DEX, it may be necessary to create an associated token account for a PDA (Program Derived Address). However, the current implementation of
createAssociatedTokenAccountin the@solana/spl-tokenlibrary has theallowOffCurveoption set to false by default whilegetAssociatedTokenAddressSync.(Reference: GitHub link)
To create an ATA for a PDA, a custom implementation is required.
Solution
This PR aims to enhance code reusability by allowing users to set the
allowOffCurveoption when usingcreateAssociatedTokenAccount.