Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

brooksprumo
Copy link
Contributor

Upgrade the rust (stable) toolchain to 1.69.0

https://blog.rust-lang.org/2023/04/20/Rust-1.69.0.html

@brooksprumo
Copy link
Contributor Author

@yihau Can I request updated CI images for this, please? Thanks in advance! 👻

@yihau
Copy link
Contributor

yihau commented Apr 25, 2023

sure thing! I uploaded and the pipeline is green now 🎉

@brooksprumo brooksprumo marked this pull request as ready for review April 25, 2023 11:15
@brooksprumo
Copy link
Contributor Author

brooksprumo commented Apr 25, 2023

Looks like coverage and stable (among others) were not run by CI since this PR did not change any .rs files.

@yihau Is there a way to force these skipped steps to be run?

Reviewers, sorry for the extra ping. I will re-add you after this is resolved.

@yihau
Copy link
Contributor

yihau commented Apr 25, 2023

ah. I think we should also update here to 1.69.0

FROM rust:1.68.2

docker files change will trigger everything!

@brooksprumo
Copy link
Contributor Author

ah. I think we should also update here to 1.69.0

FROM rust:1.68.2

docker files change will trigger everything!

Ah, thanks for pointing that out; I missed that file. Will do!

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #31336 (d62d765) into master (cece64d) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #31336     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         733      733             
  Lines      207071   207071             
=========================================
- Hits       168910   168906      -4     
- Misses      38161    38165      +4     

Copy link
Contributor

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hehe, so our nightly is older than stable from now. (upgrading nightly almost is unblocked)

also, fastest rustc bump since the last one #31276, iirc. lol

@brooksprumo brooksprumo merged commit cd2b2d4 into solana-labs:master Apr 25, 2023
@brooksprumo brooksprumo deleted the rust/1.69.0 branch April 25, 2023 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants