This repository was archived by the owner on Jan 22, 2025. It is now read-only.
CI: Add back some downstream SPL jobs #32986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Aug 24, 2023
joncinque
force-pushed
the
somedownstream
branch
from
d40f05a to
e81c503
Compare
|
Rebased on top of #32982 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#32983 took a big hammer and removed all downstream SPL jobs, when only the "checks" and "tests" jobs failed during CI: https://github.com/solana-labs/solana/actions/runs/5968320899/job/16191912388?pr=32982
Summary of Changes
Add back all of the tests that depend on the SDK, keep the CLI tests disabled.
Since this PR reverts a commit and then disabling two sets of jobs, deleting and then reverting this PR doesn't really work anymore, so I went with
if: falsefor the steps affected by the CLI changes.Fixes #