Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

bump nightly to 2023-08-25 #33048

Closed
wants to merge 5 commits into from
Closed

bump nightly to 2023-08-25 #33048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dc3826
DONOTMERGE: work around nightly ICE
t-nelson Aug 26, 2023
edb503b
DONOTMERGE: invalid reference casting UB
t-nelson Aug 26, 2023
c6b3e2a
DONOTMERGE: allow lint false positive
t-nelson Aug 26, 2023
9bb423e
DONOTMERGE: allow `clippy::items-after-test-module` due to `test-case…
t-nelson Aug 26, 2023
81337b3
bump rust nightly to 2023-08-25
t-nelson Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions gossip/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ num-traits = { workspace = true }
rand = { workspace = true }
rand_chacha = { workspace = true }
rayon = { workspace = true }
rustversion = { workspace = true }
serde = { workspace = true }
serde_bytes = { workspace = true }
serde_derive = { workspace = true }
Expand Down
4 changes: 4 additions & 0 deletions gossip/src/cluster_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,6 +1972,10 @@ impl ClusterInfo {
// Returns a predicate checking if the pull request is from a valid
// address, and if the address have responded to a ping request. Also
// appends ping packets for the addresses which need to be (re)verified.
//
// allow lint false positive trait bound requirement (`CryptoRng` only
// implemented on `&'a mut T`
#[rustversion::attr(since(1.73), allow(clippy::needless_pass_by_ref_mut))]
Comment on lines +1976 to +1978
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment pretty much covers it. allegedly this lint was introduced in 1.72, but that version was complaining that it doesn't know about it, hence the toolchain version gating.

i'm guessing this one won't be contentious and we can just put it in with a corresponding tracking issue

fn check_pull_request<'a, R>(
&'a self,
now: Instant,
Expand Down
1 change: 1 addition & 0 deletions programs/sbf/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.