CI: Move whole repo to a Makefile #101
Conversation
#### Problem The Makefile model works, but this repo is still using the package.json scripts. #### Summary of changes Similar to most other repos: * remove old scripts / workflows / setup action / package.json * update tracing-subscriber for audit failure * add Makefile
Makefile
Outdated
| @@ -0,0 +1,118 @@ | |||
| RUST_TOOLCHAIN_NIGHTLY = nightly-2025-02-16 | |||
| SOLANA_CLI_VERSION = 3.0.0 | |||
There was a problem hiding this comment.
This program's deps didn't get bumped yet.
| SOLANA_CLI_VERSION = 3.0.0 | |
| SOLANA_CLI_VERSION = 2.3.4 |
There was a problem hiding this comment.
I believe these configs can also come out of the manifest's [workspace.metadata.cli] section now, too?
There was a problem hiding this comment.
In most cases yes, but we do use the format toolchain in codama client generation, so we'll need some other way to extract them later
There was a problem hiding this comment.
Codama has a toolchain arg for its Rust renderer. You can probably hack it into the JS script to read from the Makefile. Maybe outside the scope of this PR though.
There was a problem hiding this comment.
Yeah that would be the approach most likely
| // Mark this test as BPF-only due to current `ProgramTest` limitations when | ||
| // CPIing into the system program | ||
| #![cfg(feature = "test-sbf")] |
There was a problem hiding this comment.
Any idea what this comment might have been alluding to? Looks really old.
There was a problem hiding this comment.
heh yeah there was an issue in program-test way back when where you couldn't reallocate accounts in CPI from native mode because we didn't serialize the accounts in the way expected by on-chain programs. I couldn't find the PR, but I very clearly remember fixing it
2 participants
Problem
The Makefile model works, but this repo is still using the package.json scripts.
Summary of changes
Similar to most other repos: