deps (js): Update @solana/kit dependency to 5.0, remove unused @solana/sysvars peer dependency #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@lorisleiva can you take a look? I know you've done these upgrades in the past |
lorisleiva
approved these changes
Dec 1, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Looks good to me. We should probably commit the lock file of the JS client before publishing the package.
Contributor
|
Hi @fedorerd, thank you for this contribution! We are looking to publish the new version of the library immediately, and I noticed there were some conflicts with the main branch (likely due to a recent version bump on our end). To get this merged and released quickly, I’ve gone ahead and manually applied your changes in a new PR. I made sure to include you as a Co-authored-by on the commit so that your profile gets full credit for the work. I'm closing this PR in favor of #151. Thanks again for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.