Skip to content

Conversation

@2501babe
Copy link
Member

part 1/3 of #387. update DepositStake and WithdrawStake to gracefully handle the onramp account in the accounts list. once this is live, part 2/3 we add it to instruction builders. after communicating with any ecosystem teams needed, part 3/3 we make it mandatory in the program

this will enable us to change the token math to include onramp stake (or possibly all sol, will have to debate), which will further allow us to implement DepositSol

i know we typically stick new accounts at the end, but this will eventually be a hard breaking change, so i preferred to keep the "all instructions have all accounts in the same order" property because it pleases me. if we really need to avoid a breaking change, we could put a onramp_stake and last_replenished_epoch on the pool struct. i would rather avoid this however because, among other reasons, it adds complexity for no benefit

also i moved the mint errors up to match the account ordering

@2501babe 2501babe self-assigned this Oct 17, 2025
allow onramp, but ignore it. eventually it will be mandatory
@2501babe
Copy link
Member Author

my thinking is to do a release and bpf deployment after this pr, #390 before or after doesnt matter, and then update the instruction builders, probably update everything to sdk 3.0, and do another release (which doesnt require a bpf deployment)

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@2501babe 2501babe merged commit 8c66e21 into solana-program:main Oct 21, 2025
18 checks passed
@2501babe 2501babe deleted the onramp-onramp branch October 21, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants