program: allow onramp in deposit/withdraw #389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1/3 of #387. update
DepositStakeandWithdrawStaketo gracefully handle the onramp account in the accounts list. once this is live, part 2/3 we add it to instruction builders. after communicating with any ecosystem teams needed, part 3/3 we make it mandatory in the programthis will enable us to change the token math to include onramp stake (or possibly all sol, will have to debate), which will further allow us to implement
DepositSoli know we typically stick new accounts at the end, but this will eventually be a hard breaking change, so i preferred to keep the "all instructions have all accounts in the same order" property because it pleases me. if we really need to avoid a breaking change, we could put a
onramp_stakeandlast_replenished_epochon the pool struct. i would rather avoid this however because, among other reasons, it adds complexity for no benefitalso i moved the mint errors up to match the account ordering