Skip to content

Conversation

@2501babe
Copy link
Member

@2501babe 2501babe commented Nov 4, 2025

tbh i dont remember why we did it this way in the first place, but it isnt necessary. we did want to get rid of the processer-style program calling on solana-program-test and also this is nice for smoke testing verified build binaries before deploying them

@2501babe 2501babe self-assigned this Nov 4, 2025
@2501babe 2501babe marked this pull request as ready for review November 4, 2025 09:33
@2501babe 2501babe requested a review from joncinque November 4, 2025 09:34
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! One nit which you can take or leave

program_test.add_program("spl_single_pool", id(), processor!(Processor::process));
program_test.prefer_bpf(false);
program_test.add_program("spl_single_pool", id(), None);
program_test.prefer_bpf(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer_bpf should default to true with https://github.com/anza-xyz/agave/blob/d3691c7bc8994edc4929b40e73ae3ff7d6ff7320/program-test/src/lib.rs#L513, so we shouldn't need this line at all

@2501babe 2501babe merged commit b427694 into solana-program:main Nov 4, 2025
18 checks passed
@2501babe 2501babe deleted the test-actual-bpf branch November 4, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants