Add interface crate #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joncinque
reviewed
Nov 18, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great overall! Mostly small things
joncinque
reviewed
Nov 20, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks really close! Just a few last bits that I noticed on this pass
Comment on lines
-4
to
-7
| //! | ||
| //! The sysvar ID is declared in [`sysvar::stake_history`]. | ||
| //! | ||
| //! [`sysvar::stake_history`]: crate::sysvar::stake_history |
Contributor
There was a problem hiding this comment.
You can do this in follow-up work, but how about bringing in solana-sysvar-id crate and implementing it for stake history in this crate?
Contributor
Author
There was a problem hiding this comment.
Yeah, I will bring the stake history sysvar on a separate PR. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While the repository contains the source files for the Stake interface, it does not define the interface crate.
Solution
This PR adds the interface
Cargo.tomlconfiguration and updates its dependencies to use the individual crates.There are 2 aspects that will be handled in separate PRs:
StakeHistorysysvar into this repository.