Skip to content

Remove SysvarSerialize trait dependency#343

Merged
grod220 merged 1 commit intomainfrom
sysvar-decoupling
Apr 1, 2026
Merged

Remove SysvarSerialize trait dependency#343
grod220 merged 1 commit intomainfrom
sysvar-decoupling

Conversation

@grod220
Copy link
Copy Markdown
Member

@grod220 grod220 commented Apr 1, 2026

Related: anza-xyz/agave#10672

Removes impl SysvarSerialize for StakeHistory and stops constructing StakeHistory test accounts via solana-account sysvar helpers.

These call sites keep the repo tied to upstream APIs that require SysvarSerialize, causing lockstep version coupling between solana-sysvar, solana-account, and solana-stake-interface.

Next steps

  • Agave
    • Stop creating StakeHistory sysvar accounts through create_account::(...) and use direct bincode serialization instead.
    • rRplace SysvarSerialize-bound StakeHistory paths in program-test / banks-client
  • Mollusk
    • Update the sysvar account construction path so StakeHistory can be handled without a SysvarSerialize bound
  • Stake repo
    • Once those upstream pieces land, re-run the stake program against the updated dependency graph to confirm no remaining StakeHistory-specific SysvarSerialize coupling remains

@grod220 grod220 requested review from 2501babe and joncinque April 1, 2026 16:14
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

@grod220 grod220 merged commit a33bb19 into main Apr 1, 2026
23 checks passed
@grod220 grod220 deleted the sysvar-decoupling branch April 1, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants