Conversation
buffalojoec
commented
Mar 4, 2025
grod220
approved these changes
Mar 5, 2025
Member
grod220
left a comment
grod220
left a comment
There was a problem hiding this comment.
LGTM, just one comment but not sure if it's addressable given the migration objectives
| errors are thrown, we inject the check here. | ||
| */ | ||
| if let Some((base_key, base_info)) = self.base { | ||
| base_key == base_info.key && base_info.is_signer |
Member
There was a problem hiding this comment.
It feels strange to have this check here and also not throw. Would it not make more sense to have a standalone check that raises an error if they don't match? Or is the objective not to make any business logic change in the migration?
Contributor
Author
There was a problem hiding this comment.
Right, as the comment above it states, it's not pretty but it's so that the program behaves exactly as the original did. Trust me, I hate it too.
febo
approved these changes
Mar 6, 2025
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks good! Just a tiny nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
AllocateWithSeedinstruction processor in the BPF version of the System builtin program.See #38 for a draft overview of the implemented base processor (no nonce instructions).