Fixed --transfer-hook CLI option not allowing default Pubkey as value #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Jul 24, 2025
Comment on lines
+354
to
+358
| let program_id: OptionalNonZeroPubkey = if let Some(program_id) = transfer_hook_program_id { | ||
| OptionalNonZeroPubkey(program_id) | ||
| } else { | ||
| OptionalNonZeroPubkey::default() | ||
| }; |
There was a problem hiding this comment.
nit: it would be a bit simpler to use unwrap_or_default(), ie
Suggested change
| let program_id: OptionalNonZeroPubkey = if let Some(program_id) = transfer_hook_program_id { | |
| OptionalNonZeroPubkey(program_id) | |
| } else { | |
| OptionalNonZeroPubkey::default() | |
| }; | |
| let program_id = transfer_hook_program_id.map(OptionalNonZeroPubkey).unwrap_or_default(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
spl-token create-token --program-2022 --transfer-hook 11111111111111111111111111111111would error out, when its expected to be a valid value that represents the lack of a transfer-hook program. This PR fixes this.