Permissioned burn extension #818
Draft
+207
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joncinque Would really appreciate a quick review, just to confirm that I’m moving in the right direction before adding the tests. |
joncinque
reviewed
Nov 4, 2025
Comment on lines
+1114
to
+1115
| // Pull the required extra signer from the accounts | ||
| let approver_ai = next_account_info(account_info_iter)?; |
There was a problem hiding this comment.
Seeing this, I think we should add a new variant to Burn, like BurnCheckedWithPermission, which explicitly takes in the authority. Otherwise, the account order for multisig owners will break, since you'll need to do:
- source account
- mint account
- account authority (non-signer)
- permissioned burn authority (signer)
- multisig signers (signer)
It would be better to be clear, and have a new instruction which orders the accounts as:
- source
- mint
- permissioned burn authority
- account authority
- multisig signers
We can add it as another instruction under the PermissionedBurn extension.
There was a problem hiding this comment.
Makes sense; definitely better than making a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a permissioned-burn extension as described in #772
TODO:
Closes #772