build(deps-dev): bump typescript from 5.5.3 to 5.7.3 in /clients/js#96
Conversation
33b273c to
e710030
Compare
|
@lorisleiva not urgent at all, but can you take a look at the issue? It looks like it's complaining because of unused code in the generated clients after compilation. Should we add a typescript flag to ignore this or fix it in the code generation? Or something else that I'm missing? |
45d2649 to
6c19a4f
Compare
|
Oh... that's annoying. I know exactly why this warning is there and I've wanted to fix it for a while now so it might be a good time to do it now that TS is getting stricter on that. Might not be for a little while though unless it's urgent. |
|
Definitely not urgent, I just wanted you to be aware of it. Thanks! |
e0e1e1a to
6c87472
Compare
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.3 to 5.7.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.3...v5.7.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
6c87472 to
6bf3262
Compare
|
Turns out the issue was not that TypeScript decided to error on that warning but simply that dependabot didn't do a great job at upgrading the lock file. A simple The reason it looked like an error on the warning is because of the lack of verbosity on the new version of I'd still like to remove that warning on Codama since it's really annoying but at least this is no longer a blocker for this PR. 🙂 |
|
Thanks for looking into it! |
Bumps typescript from 5.5.3 to 5.7.3.
Release notes
Sourced from typescript's releases.
... (truncated)
Commits
a5e123dUpdate LKG8bc0204🤖 Pick PR #60828 (Fix CodeQL configuration, releases) into release-5.7 (#60923)7aa63df🤖 Pick PR #60393 (Don't try to add an implicit undefi...) into release-5.7 (#...9df7c36Bump version to 5.7.3 and LKGe167412🤖 Pick PR #60794 (HardensanitizeLogagainst incorr...) into release-5.7 (#...9ba364cFix coverage build on release-5.7 (#60792)4b7441a🤖 Pick PR #60680 (Mark the inherited any-based index ...) into release-5.7 (#...e844dc3Cherry-pick #60402, #60440, #60616 into release-5.7 (#60777)21b02a1🤖 Pick PR #60749 (Do not require import attribute on ...) into release-5.7 (#...b82fd16🤖 Pick PR #60576 (Avoid incorrectly reusing assertion...) into release-5.7 (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)